chore: fix "react-in-jsx-scope" ESLint errors #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes all 50 violations of the [`react/react-in-jsx-scope`][0] lint rule. In the docs for that rule: > If you are using the [new JSX transform from React 17][1], you should > disable this rule by extending `react/jsx-runtime` in your eslint > config (add `"plugin:react/jsx-runtime"` to `"extends"`). We are, so we can do this! It also lets us remove many `React` imports. [0]: https://github.com/jsx-eslint/eslint-plugin-react/blob/4467db503e38b9356517cf6926d11be544ccf4b1/docs/rules/react-in-jsx-scope.md [1]: https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html
ErikSin
force-pushed
the
fix-react-in-scope-when-using-jsx-eslint
branch
from
8dcf2ea to
715e1c0
Compare
|
GitHub Build Trigger Failure The build trigger failed with the following error: Please check your GitHub app installation settings and your Expo project's GitHub settings to make sure you've configured everything correctly. |
|
I am not going to merge this right now. There are alot of active branches and this touches over 50 files, so it is going to cause alot of git problems. I think we should do this eventually, but maybe after MVP when some of us have switched to working on desktop (and there is not 6 people with multiple different branches working on this repo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all 50 violations of the
react/react-in-jsx-scopelint rule.In the docs for that rule:
We are, so we can do this! It also lets us remove many
Reactimports.