feat: add env variables schema and validation #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so supportedLanguages find method
…e into feat/expo-prebuild
|
Im going to close this for now. Thanks for doing this work but I dont think this a priorty for this time. But when this work is done later, i will use this PR for reference, so the work was not done in vain. |
|
Sure, that's absolutely fine. I'll open new PR tomorrow with only required changes from this one (mapbox token from env, merging app.json into app.config.js). Thanks for considering this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces schema for environment variables that is checked upon app start. It also lists all possible env vars used across the app. This will definitely improve developer experience. It wasn't listed as an issue so if you feel like this is redundant addition feel free to close this PR without merging.
