feat: observations list as a tab #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/save-track
…eet modal, and fixed padding in discription input
ErikSin
commented
Apr 30, 2024
Comment on lines
-7
to
+10
| export enum TabName { | ||
| Map = 'Map', | ||
| Camera = 'Camera', | ||
| Tracking = 'Tracking', | ||
| } | ||
| export type TabName = keyof HomeTabsList; |
There was a problem hiding this comment.
I replaced this enum with a type
achou11
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Changes look generally good. Couple of questions:
-
How do we get to the settings screen now that the button has been removed from the ObservationsList screen?
-
Couple of small issues with the tab icon (i'm okay with them being addressed in a follow-up):
- the highlighting when active looks off. guessing that's an issue with the asset and will need to replace it.
- size is a little bigger than the other tab icons
src/frontend/screens/ObservationsList/ObservationListHeader.tsx
Outdated
Show resolved
Hide resolved
src/frontend/screens/ObservationsList/ObservationListHeader.tsx
Outdated
Show resolved
Hide resolved
src/frontend/screens/ObservationsList/ObservationListHeader.tsx
Outdated
Show resolved
Hide resolved
achou11
reviewed
May 1, 2024
For posterity, the next PR I will be working on introduces the setting drawer which will replace the settings screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds observation list as tab in the home screen.
closes #307