feat: update header with new UI #312
Conversation
ErikSin
changed the title
| const handleDetailsPress = React.useCallback(() => { | ||
| navigation.navigate('ObservationDetails', {question: 1}); | ||
| }, [navigation]); | ||
| // const handleDetailsPress = React.useCallback(() => { | ||
| // navigation.navigate('ObservationDetails', {question: 1}); | ||
| // }, [navigation]); |
There was a problem hiding this comment.
this will be added really soon, so just commented out for linting purposes
| editDeviceInfoMutation.mutate, | ||
| editDeviceInfoMutation.isPending, | ||
| editDeviceInfoMutation, | ||
| nameHasChanges, | ||
| errorModal.openSheet, |
There was a problem hiding this comment.
this was not playing well with the linter, so i just added the entire object
There was a problem hiding this comment.
if you extract the field first and use that, it should work e.g.
const {openSheet} = useBottomSheetModal({openOnMount: false});i think adding the whole object is not desirable (in theory) because the effect will run if when one of its fields changes (e.g. isOpen). maybe it's not a big issue in practice though 🤷
| }, | ||
| { | ||
| onPress: closeSheet, | ||
| text: formatMessage(m.discardCancel), |
There was a problem hiding this comment.
nit: Seeing the cancel action copy of Continue editing seems a little off when you're on the category chooser screen.
There was a problem hiding this comment.
Im going to leave this because we are planning on updating all the copy at a later time, so that can be dealt with then
| editDeviceInfoMutation.mutate, | ||
| editDeviceInfoMutation.isPending, | ||
| editDeviceInfoMutation, | ||
| nameHasChanges, | ||
| errorModal.openSheet, |
There was a problem hiding this comment.
if you extract the field first and use that, it should work e.g.
const {openSheet} = useBottomSheetModal({openOnMount: false});i think adding the whole object is not desirable (in theory) because the effect will run if when one of its fields changes (e.g. isOpen). maybe it's not a big issue in practice though 🤷
Updated the header in creating/editting an observation to include new save button. Also replaces the native toast with a modal for confirming whether user wants to discard changes when trying to leave the edit screen.