-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Es/feat drawer navigation #351
Conversation
3dcec73
to
c13cd97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't read through implementation just yet, but here are some initial UI suggestions to make it closer to the intended design (see screenshots at bottom for frame of reference):
-
Increase font size and weight of all text items (should match design when using default OS system settings for fonts)
-
Grey box should extend over the safe area too
-
Use lighter shade of grey for grey box
-
horizontal spacing between the row icon and the text is a bit too large
-
maybe increase the horizontal padding around the text in the grey box? seems like the design has it so that the text never flows under the drawer icon. not as adamant/sure about this one though
-
Is there a drawer icon that matches the design? the one in the design has rounded ends whereas the one used in the implementation does not
-
are the tutorial row + items at the bottom of the drawer (about and privacy policy) intentionally excluded from the implementation for now?EDIT: not relevant, since this PR just ports the existing items, which is reasonable
What's currently implemented:
Expected design:
c13cd97
to
8d8b64d
Compare
This is a really annoying problem to fix. I think the < list /> actually needs to be refactored. The < ListIcon /> is hardcoded with a So this is a temp solution that doesn't break all the other implementations of it. |
i fixed the header size |
addressed via fb37bbf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of smaller pieces of feedback but otherwise the implementation feels good!
); | ||
}; | ||
|
||
const DrawerContent = ({navigation}: DrawerContentComponentProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should create a stylesheet for this component and extract the inline styles out into it
Add drawer navigation