Feat observation fields #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@achou11 alot of this is ported over from mapeo-mobile |
achou11
approved these changes
May 15, 2024
|
|
||
| const defaultAcc: Field[] = []; | ||
| const fields = !fieldsQuery.data | ||
| ? undefined | ||
| const fields = !data |
There was a problem hiding this comment.
nit: invert the ternary to avoid the negation
| @@ -61,7 +59,7 @@ export const ObservationScreen: NativeNavigationComponent<'Observation'> = ({ | |||
| const {lat, lon, createdBy} = observation; | |||
| const isMine = deviceId === createdBy; | |||
| // Currently only show photo attachments | |||
| const photos = []; | |||
| // const photos = []; | |||
There was a problem hiding this comment.
nit: maybe just remove this + comment above?
| // onPress: handleDetailsPress, | ||
| // }); | ||
| // } | ||
| if (preset?.fieldIds && preset.fieldIds.length) { |
There was a problem hiding this comment.
nit: think this can be shortened?
Suggested change
| if (preset?.fieldIds && preset.fieldIds.length) { | |
| if (preset?.fieldIds?.length) { |
| {...m.title} | ||
| values={{ | ||
| current: questionNumber, | ||
| total: !preset ? 0 : preset.fieldIds.length, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add observation fields to observation edit screen and displays observations fields when viewing an observation