Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: media management logic #885

Merged
merged 5 commits into from
Dec 11, 2024
Merged

chore: media management logic #885

merged 5 commits into from
Dec 11, 2024

Conversation

cimigree
Copy link
Contributor

@cimigree cimigree commented Dec 9, 2024 •
edited
Loading

Closes #879

Description

  • Adds new hook to use backend functions for getting and setting the media sync settings.
  • Uses those new hooks in the media sync screen
  • Takes the media sync settings out of local settings/ state
  • Takes out the media management flag

@cimigree cimigree requested a review from ErikSin December 9, 2024 23:35
ErikSin
ErikSin requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ErikSin ErikSin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job. just some slight adjustments to account for the fact that we are going to be using suspense moving forward AND there is some state syncing that should be avoided (but the suspense will help with that)

src/frontend/hooks/server/mediaSync.ts Outdated Show resolved Hide resolved
src/frontend/screens/Settings/ProjectSettings/MediaSyncSettings.tsx Outdated Show resolved Hide resolved
src/frontend/screens/Settings/ProjectSettings/MediaSyncSettings.tsx Outdated Show resolved Hide resolved
@cimigree cimigree requested a review from ErikSin December 10, 2024 15:46
@cimigree cimigree requested a review from ErikSin December 11, 2024 15:10
ErikSin
ErikSin approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ErikSin ErikSin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cindy! Looks great

@cimigree cimigree merged commit cb2cee3 into develop Dec 11, 2024
3 checks passed
@cimigree cimigree deleted the chore/media-mgmt-logic branch December 11, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSin ErikSin ErikSin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add logic for media management
2 participants
@cimigree @ErikSin