Skip to content

Commit

Permalink
Field type requirement cleanup
Browse files Browse the repository at this point in the history
Co-Authored-By: Gregor MacLennan <[email protected]>
  • Loading branch information
EvanHahn and gmaclennan committed Sep 16, 2024
1 parent f042b7a commit 5faaba6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion proto/field/v1.proto
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ message Field_1 {
selectOne = 3;
selectMultiple = 4;
}
Type type = 6 [(required) = true];
Type type = 6;
string label = 7 [(required) = true];
enum Appearance {
appearance_unspecified = 0;
Expand Down
1 change: 0 additions & 1 deletion src/lib/decode-conversions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ export const convertField: ConvertFunction<'field'> = (message, versionObj) => {
const { common, schemaVersion, tagKey, type, label, ...rest } = message
const jsonSchemaCommon = convertCommon(common, versionObj)
ensure(tagKey, 'field', 'tagKey')
ensure(type !== 'type_unspecified', 'field', 'type')
return {
...jsonSchemaCommon,
...rest,
Expand Down

0 comments on commit 5faaba6

Please sign in to comment.