Skip to content

Commit

Permalink
fix!: make Observation metadata coords fields optional
Browse files Browse the repository at this point in the history
This object should match [how we collect the data on the frontend][0].

Closes [#231].

[0]: https://docs.expo.dev/versions/latest/sdk/location/#locationobjectcoords
[#231]: https://github.com/digidem/mapeo-schema/issues/231
  • Loading branch information
EvanHahn committed Aug 30, 2024
1 parent cf89ad7 commit 9f309d2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
8 changes: 4 additions & 4 deletions proto/observation/v1.proto
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ message Observation_1 {
message Coords {
double latitude = 1;
double longitude = 2;
double altitude = 3;
double heading = 4;
double speed = 5;
double accuracy = 6;
optional double altitude = 3;
optional double heading = 4;
optional double speed = 5;
optional double accuracy = 6;
}
optional Coords coords = 3;
}
Expand Down
9 changes: 1 addition & 8 deletions schema/observation/v1.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,7 @@
"coords": {
"description": "Position details, should be self explanatory. Units in meters",
"type": "object",
"required": [
"latitude",
"longitude",
"altitude",
"heading",
"speed",
"accuracy"
],
"required": ["latitude", "longitude"],
"properties": {
"latitude": {
"type": "number"
Expand Down

0 comments on commit 9f309d2

Please sign in to comment.