add validation for protobuf, add testing of wrong validation

package.json

@@ -56,7 +56,8 @@
     "protobufjs": "^7.2.5",
     "type-fest": "^4.1.0",
     "typedoc": "^0.24.8",
-    "typedoc-plugin-markdown": "^3.15.4"
+    "typedoc-plugin-markdown": "^3.15.4",
+    "validate-color": "^2.2.4"
   },
   "eslintConfig": {
     "env": {

src/lib/encode-conversions.ts

@@ -18,6 +18,7 @@ import {
 } from '../proto/observation/v5.js'
 import { ExhaustivenessError, parseVersionId } from './utils.js'
 import { CoreOwnership, type Observation, type Track } from '../index.js'
+import validateColor from 'validate-color'
 
 /** Function type for converting a protobuf type of any version for a particular
  * schema name, and returning the most recent JSONSchema type */
@@ -66,6 +67,9 @@ export const convertField: ConvertFunction<'field'> = (mapeoDoc) => {
 }
 
 export const convertPreset: ConvertFunction<'preset'> = (mapeoDoc) => {
+  if (!validateColor.validateHTMLColorHex(mapeoDoc.color)) {
+    throw new Error(`invalid color string ${mapeoDoc.color}`)
+  }
   return {
     common: convertCommon(mapeoDoc),
     ...mapeoDoc,

test/fixtures/bad-docs.js

@@ -62,4 +62,25 @@ export const badDocs = [
       ],
     },
   },
+  {
+    text: 'preset with invalid color string',
+    doc: {
+      docId: cachedValues.docId,
+      versionId: cachedValues.versionId,
+      schemaName: 'preset',
+      createdAt: cachedValues.createdAt,
+      updatedAt: cachedValues.updatedAt,
+      createdBy: cachedValues.createdBy,
+      links: [],
+      name: 'myPreset',
+      geometry: ['point'],
+      tags: {},
+      addTags: {},
+      removeTags: {},
+      fieldIds: [],
+      terms: [],
+      deleted: false,
+      color: '#ff00g1',
+    },
+  },
 ]

test/index.test.js

@@ -29,6 +29,15 @@ test('Bad docs throw when encoding', () => {
   }
 })
 
+test(`Bad docs won't validate`, () => {
+  for (const { text, doc } of badDocs) {
+    assert.throws(() => {
+      // @ts-expect-error
+      validate(doc)
+    }, text)
+  }
+})
+
 test('validate bad docs', () => {
   for (const schemaName of Object.keys(currentSchemaVersions)) {
     assert(