-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up deps #212
chore: clean up deps #212
Conversation
package.json
Outdated
"@types/json-schema": "^7.0.12", | ||
"c8": "^8.0.1", | ||
"cpy-cli": "^5.0.0", | ||
"eslint": "^8.46.0", | ||
"glob": "^11.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this lacks support for Node <20 and we develop on Node 18, is this a safe update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm right. i forgot that CI is doing this in Node 18 as well. will revert that change.
in terms of modules consuming this module, I wouldn't expect this to break if glob is defined as a dev dep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw though, CI on Node 18 passed before downgrading: https://github.com/digidem/mapeo-schema/pull/212/checks?sha=fe73a329800b2046875ff237217fdfcfbcdecab2
just to confirm, is https://github.com/digidem/mapeo-schema/blob/3a2ca671901414e7ae5cf913b4e771066596cf98/scripts/lib/generate-validations.js#L3 because i wasn't sure what that code pulls in. But based on the generated output, seems like it's adhering to "standalone" and not relying on the presence of |
It looks like that's only run by |
Summary of changes:
@json-schema-tools/dereferencer
: upgrades to^1.6.3
and move to dev depsajv
: move to dev depsajv-formats
: removedglob
: update to v11 (removes node support for < 20) and move to dev deps