Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up deps #212

Merged
merged 3 commits into from
Aug 14, 2024
Merged

chore: clean up deps #212

merged 3 commits into from
Aug 14, 2024

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Aug 14, 2024

Summary of changes:

  • @json-schema-tools/dereferencer: upgrades to ^1.6.3 and move to dev deps
  • ajv: move to dev deps
  • ajv-formats: removed
  • glob: update to v11 (removes node support for < 20) and move to dev deps

@achou11 achou11 requested a review from EvanHahn August 14, 2024 15:31
package.json Outdated
"@types/json-schema": "^7.0.12",
"c8": "^8.0.1",
"cpy-cli": "^5.0.0",
"eslint": "^8.46.0",
"glob": "^11.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this lacks support for Node <20 and we develop on Node 18, is this a safe update?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm right. i forgot that CI is doing this in Node 18 as well. will revert that change.

in terms of modules consuming this module, I wouldn't expect this to break if glob is defined as a dev dep

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@achou11 achou11 Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achou11
Copy link
Member Author

achou11 commented Aug 14, 2024

just to confirm, is ajv truly only used in build time? This had me a little bit on the fence:

https://github.com/digidem/mapeo-schema/blob/3a2ca671901414e7ae5cf913b4e771066596cf98/scripts/lib/generate-validations.js#L3 because i wasn't sure what that code pulls in. But based on the generated output, seems like it's adhering to "standalone" and not relying on the presence of ajv to be installed

@EvanHahn
Copy link
Contributor

It looks like that's only run by npm run build, which isn't run by consumers of this package (I think). I assume this is safe to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants