Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[story/CICO-15] added Jupyter Notebooks to project; added some exception handling, made item type configurable, and a couple small additions #12

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jophals
Copy link

@jophals jophals commented Dec 11, 2024

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

Make better versions of the 'Download' and 'Upload' Jupyter notebooks. They should be configurable regarding type of document, etc. also, it should handle downloads that are not complete yet.

Anything else the reviewer needs to know?

…ion handling, made item type configurable, and a couple small additions
@jophals jophals requested a review from jdamerow December 11, 2024 00:01
@jophals jophals self-assigned this Dec 11, 2024
Copy link
Member

@jdamerow jdamerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one or two comments in line, but generally there should be no urls in here and no cell output.

Download.ipynb Outdated
"GROUP_ID = \"\"\n",
"CITESPHERE_API_URL = const.CITESPHERE_API_URL\n",
"TOKEN = \"\"\n",
"GILES_ROOT = \"https://diging.asu.edu/geco-giles-staging\""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url should not be in here

Download.ipynb Outdated
"source": [
"FOLDER_NAME = \"download/\"\n",
"GROUP_ID = \"\"\n",
"CITESPHERE_API_URL = const.CITESPHERE_API_URL\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probalby be specified here, not in const

@jdamerow jdamerow closed this Dec 20, 2024
@jophals jophals reopened this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants