Separate MeterFilter from Meters #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MeterFilter which add the common tag application="YourApp" to all meters is removed from the ApplicationInfoMetrics, and instead must be configured separately when initializing your MeterRegistry in order to ensure the filter is configured _before_ any bound Meter.
runeflobakk
force-pushed
the
separate-appinfo-and-application-tag
branch
from
85f1589 to
30c8111
Compare
runeflobakk
commented
Jun 6, 2024
Comment on lines
-87
to
-105
| private void addTagIfValuePresent(List<Tag> tags, String tagKey, String valueName) { | ||
| fromManifestOrEnv(valueName).ifPresent(value -> tags.add(Tag.of(tagKey, value))); | ||
| } | ||
|
|
||
| private Optional<String> fromManifestOrEnv(String name) { | ||
| String value = environmentVariableOrSystemProperty(name); | ||
| if (value == null) { | ||
| value = manifest.getMainAttributes().getValue(name); | ||
| } | ||
| return ofNullable(value); | ||
| } | ||
|
|
||
| private static String environmentVariableOrSystemProperty(String name) { | ||
| String value = System.getProperty(name); | ||
| if (value == null) { | ||
| value = System.getenv(name); | ||
| } | ||
| return value; | ||
| } |
There was a problem hiding this comment.
The use of these methods has been refactored to the concept of a KeyValueResolver which are composed of possibly multiple sources in order of precedence. This is set up in the constructor to first check system props, then environment args, and lastly the MANIFEST.MF.
eivinhb
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MeterFilter which add the common tag application="YourApp" to all meters is removed from the ApplicationInfoMetrics, and instead must be configured separately when initializing your MeterRegistry in order to ensure the filter is configured before any bound Meter.
This allows for some flexibility. E.g to actually configure the filter or not:
Alternatively if you do not care if the filter was configured or not, and don't need it logged:
Or resolve to a fallback filter, should the application name discovery from the MANIFEST.MF fail:
Or You may also simply do this, and avoid all magic discovery, should you prefer to avoid magic discovery:
Note: this should be done before any meters are bound to the registry, in order for the filter to be effective for all meters.