Handle manifests that fail to deserialize

src/IIIF/IIIF.Tests/Serialisation/CookbookDeserialization.cs

@@ -11,7 +11,7 @@ public class CookbookDeserialization
     public void Can_Deserialize_Cookbook_Manifest(string manifestId, Manifest manifest)
     {
         // perfunctory assertion
-        manifest.Should().NotBeNull();
+        manifest.Should().NotBeNull($"{manifestId} is a valid cookbook manifest");
         manifest.Id.Should().Be(manifestId);
     }
 }

src/IIIF/IIIF.Tests/Serialisation/Data/CookbookManifestData.cs

@@ -1,55 +1,64 @@
-using System.Collections;
-using System.Collections.Generic;
-using System.Net.Http;
-using IIIF.Presentation.V3;
-using IIIF.Serialisation;
-
-namespace IIIF.Tests.Serialisation.Data;
-
-/// <summary>
-/// Used as [ClassData] - contains Manifests from IIIF Cookbook to validate deserialisation
-/// </summary>
-public class CookbookManifestData : IEnumerable<object[]>
-{
-    // This will store { manifest-id, deserialized-manifest }
-    private readonly List<object[]> data = new();
-
-    // these have bugs in the cookbook, see https://github.com/IIIF/cookbook-recipes/pull/546
-    private List<string> skip = new()
-    {
-        "https://iiif.io/api/cookbook/recipe/0219-using-caption-file/manifest.json",
-        "https://iiif.io/api/cookbook/recipe/0040-image-rotation-service/manifest-service.json"
-    };
-
-    public CookbookManifestData()
-    {
-        using var httpClient = new HttpClient();
-        var theseusCollection =
-            GetIIIFResource<Collection>("https://theseus-viewer.netlify.app/cookbook-collection.json", true);
-
-        foreach (var item in theseusCollection.Items!)
-        {
-            if (item is Manifest manifestRef)
-            {
-                if (skip.Contains(manifestRef.Id)) continue;
-
-                var iiif = GetIIIFResource<Manifest>(manifestRef.Id);
-                data.Add(new object[] { manifestRef.Id, iiif });
-            }
-        }
-
-        T GetIIIFResource<T>(string url, bool mustSucceed = false) where T : JsonLdBase
-        {
-            var resource = httpClient.GetAsync(url).Result;
-            if (mustSucceed) resource.EnsureSuccessStatusCode();
-            if (!resource.IsSuccessStatusCode) return null;
-
-            var iiif = resource.Content.ReadAsStream().FromJsonStream<T>();
-            return iiif;
-        }
-    }
-
-    public IEnumerator<object[]> GetEnumerator() => data.GetEnumerator();
-
-    IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
+using System;
+using System.Collections;
+using System.Collections.Generic;
+using System.Net.Http;
+using IIIF.Presentation.V3;
+using IIIF.Serialisation;
+
+namespace IIIF.Tests.Serialisation.Data;
+
+/// <summary>
+/// Used as [ClassData] - contains Manifests from IIIF Cookbook to validate deserialisation
+/// </summary>
+public class CookbookManifestData : IEnumerable<object[]>
+{
+    // This will store { manifest-id, deserialized-manifest }
+    private readonly List<object[]> data = new();
+
+    // these have bugs in the cookbook, see https://github.com/IIIF/cookbook-recipes/pull/546
+    private List<string> skip = new()
+    {
+        "https://iiif.io/api/cookbook/recipe/0219-using-caption-file/manifest.json",
+        "https://iiif.io/api/cookbook/recipe/0040-image-rotation-service/manifest-service.json"
+    };
+
+    public CookbookManifestData()
+    {
+        using var httpClient = new HttpClient();
+        var theseusCollection =
+            GetIIIFResource<Collection>("https://theseus-viewer.netlify.app/cookbook-collection.json", true);
+
+        foreach (var item in theseusCollection.Items!)
+        {
+            if (item is Manifest manifestRef)
+            {
+                if (skip.Contains(manifestRef.Id)) continue;
+
+                var iiif = GetIIIFResource<Manifest>(manifestRef.Id);
+                data.Add(new object[] { manifestRef.Id, iiif });
+            }
+        }
+
+        T GetIIIFResource<T>(string url, bool mustSucceed = false) where T : JsonLdBase
+        {
+            var resource = httpClient.GetAsync(url).Result;
+            if (mustSucceed) resource.EnsureSuccessStatusCode();
+            if (!resource.IsSuccessStatusCode) return null;
+
+            try
+            {
+                var iiif = resource.Content.ReadAsStream().FromJsonStream<T>();
+                return iiif;
+            }
+            catch (Exception)
+            {
+                if (mustSucceed) throw;
+                return null;
+            }
+        }
+    }
+
+    public IEnumerator<object[]> GetEnumerator() => data.GetEnumerator();
+
+    IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
 }