Restore lf value normalization #20791
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore #19989 which had been rolled back in #20171. The rollback PR was rolling back both value normalization and #20036 at the same time to fix an ACS import issue: https://github.com/DACH-NY/canton-network-node/issues/15640. However, only #20036 was responsible for the ACS import issue as far as I can tell, and #20171 alone should be safe.
Said otherwise, we're now normalizing (i.e. dropping trailing Nones) LF values produced by the engine, but we're not requiring that disclosures (or any input contract) should be normalized.
TODO: expand on what this fixes and the consequences
I had to amend the cherry-pick commit to accommodate changes that have been merged since, but only the test part. The normalization logic was merged without any conflict.