python: Move the remaining unit tests off of starting their own Sandbox #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the remaining unit tests off of starting their own Sandbox and explicitly declaring Party literals.
There are some tests that require specialized setups; they have all been dropped:
test_static_time: static time is a deprecated feature of Sandbox, so attempting to reimplement this configuration in a way that works with the new CircleCI setup as outlined in Migrate build and tests to the latest version of the DAML SDK #75 is not worth it.test_ssl: SSL tests will be reimplemented in the new setup via an nginx sidecar that also runs as part of the build that fronts the non-SSL sandbox that is run with the tests. The current SSL test has been skipped since beforedazlwas open-sourced, so it needs to be rewritten as part of a PR that focuses specifically on remediating the state of the SSL code indazl.test_sandbox_wrapper: this test validates the behavior of thesandboxwrapper function that launches asandboxas part of tests, which this PR aims to remove its entirety.