Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial support for ghc-9.12.1 #560

Merged

Conversation

shayne-fletcher
Copy link
Contributor

the ghc-9.12 backport branch has been cut, this PR adds initial support for ghc-9.12.1.

@shayne-fletcher shayne-fletcher requested a review from a team as a code owner October 10, 2024 22:17
Copy link

@dylant-da dylant-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the question below. Thanks for getting this through - are you still able to access our shared Slack channel?

f | Ghc9101 <= f && f < GhcMaster -> GHC_9_10
GhcMaster -> GHC_9_12
f | Ghc9101 <= f && f < Ghc9121 -> GHC_9_10
f | Ghc9121 <= f && f < GhcMaster -> GHC_9_14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to write GHC_9_12 here? I would assume so judging by the pattern?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! pushed a fix.

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@shayne-fletcher shayne-fletcher force-pushed the ghc-9.12-inital-support branch from 7634215 to 5dbcf78 Compare October 11, 2024 15:20
@shayne-fletcher
Copy link
Contributor Author

LGTM, pending the question below. Thanks for getting this through - are you still able to access our shared Slack channel?

no, i don't seem to have access to any da slack channels anymore

@shayne-fletcher shayne-fletcher force-pushed the ghc-9.12-inital-support branch from 5dbcf78 to f63ab1d Compare October 12, 2024 18:17
@dylant-da dylant-da enabled auto-merge (squash) October 14, 2024 09:19
@dylant-da dylant-da merged commit 4298fd3 into digital-asset:master Oct 14, 2024
40 checks passed
@shayne-fletcher shayne-fletcher deleted the ghc-9.12-inital-support branch October 14, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants