Remove pSupportedExts from ParserOpts #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylant-da
approved these changes
Nov 26, 2024
|
i've been down this road before and the choices i've made here ("flattening the cases") is deliberate based on the experience even if it does mean more lines of code 🙂 if it's ok with you i'd prefer to lay it out this way |
|
I figured there was a reason, I noticed just about everything is flattened in the rest of the codebase too. Thanks a lot for getting this through! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapt to
caaf53881d5cc82ebff617f39ad5363429d2eccf.two small changes:
getOptionssUnitSettingsofSettings.