Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ghc-flavor ghc-9.8.4 #571

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

shayne-fletcher
Copy link
Contributor

@shayne-fletcher shayne-fletcher commented Nov 30, 2024

  • add support for ghc-9.8.4

    • this required replacing atomic_inc64 with atomic_inc in 'genSym.c' ((i) pre 9.8.4 RTS don't have atomic_inc64 (ii) atomic_inc did for 9.8.3 it will do here (iii) atomic_inc on 64-bit platforms appears equivalent in effect (iv) all of this is eliminated from 'genSym.c' in later versions of GHC)
  • delete .github/workflows/ghc-9.8.2-ghc-9.6.5.yml and replace it with .github/workflows/ghc-9.8.4-ghc-9.6.5.yml

    • i expect because of this, the branch protection rules for this repository will need to be updated (the list of workflows that are required to run before merging) after merging this PR
  • i also tweaked the filepath lower bounds in the 9.8 and 9.10 cases (making them more consistent with GHC)

@shayne-fletcher shayne-fletcher requested a review from a team as a code owner November 30, 2024 13:05
Copy link

@dylant-da dylant-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this!
I'll contact Richard on our end to ask about the workflow changes.

@dylant-da
Copy link

Looks like gitlab failed to resolve, possibly a flake, restarting

@shayne-fletcher
Copy link
Contributor Author

@dylant-da

Looks like gitlab failed to resolve, possibly a flake, restarting

i just saw a post to the GHC Devs list about https://ghc.gitlab.haskell.org gives 502 bad gateway for Liquid Haskell so we are not the only project affected.

@dylant-da dylant-da merged commit 3311818 into digital-asset:master Dec 3, 2024
40 checks passed
@shayne-fletcher shayne-fletcher deleted the ghc-9.8.4-release branch December 3, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants