Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict alex < 3.5.2.0, more ghc-9.8.4 fixes and ghc-9.12.1 as a build compiler #577

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shayne-fletcher
Copy link
Contributor

@shayne-fletcher shayne-fletcher commented Dec 31, 2024

(commit 245912d): alex-3.5.2.0 was released to hackage on 2024-12-30. it produces errors like this

compiler/GHC/Parser/Lexer.x:3471:12: error: [GHC-31744]
    Duplicate INLINE pragmas for ‘alexScanUser’
    at /home/runner/work/ghc-lib/ghc-lib/dist-newstyle/build/x86_64-linux/ghc-9.10.1/ghc-lib-parser-0.20241231/build/GHC/Parser/Lexer.hs:1383:12-23
       compiler/GHC/Parser/Lexer.x:3471:12-23
     |
3471 | -- in this file, alexScanUser gets broken out into a separate function and
     |            ^^^^^^^^^^^^

on flavors >= ghc-9.12.1 e.g. https://github.com/digital-asset/ghc-lib/actions/runs/12553438884. verified that this is a problem for GHC too. see haskell/alex#266

(commit 81196e9): two more fixes relating to 9.8.4 as a build compiler

  • hide os-string during calculating parser module deps in ghc-lib-gen to avoid ambiguity with filepath
  • avoid link errors resulting from duplicate symbol definitions from 'genSym.c'

(commit 27e2421): add an exclusion to ghc-lib's hs-src dirs

(commit 29ca22c): haskell-hvr/cryptohash-sha256#25 got closed enabling us to remove the extra hadrian cabal flags from 'Ghclibgen.hs' and ghcup now serves ghc-9.12.1 (since 2024-12-15 looks like) so, move ghc-lib-ghc-HEAD-ghc-9.10.1.yml to ghc-lib-ghc-HEAD-ghc-9.12.1.yml, ghc-lib-ghc-master-ghc-9.10.1.yml to ghc-lib-ghc-master-ghc-9.12.1.yml (updating the build compiler to ghc-9.12.1 accordingly) and update the README build badge (after landing this it's probably necessary to modify the repository "required test" settings).

@shayne-fletcher shayne-fletcher requested a review from a team as a code owner December 31, 2024 13:57
@shayne-fletcher shayne-fletcher changed the title restrict alex < 3.5.2.0 restrict alex < 3.5.2.0 and more ghc-9.8.4 fixes Jan 3, 2025
@shayne-fletcher shayne-fletcher changed the title restrict alex < 3.5.2.0 and more ghc-9.8.4 fixes restrict alex < 3.5.2.0, more ghc-9.8.4 fixes and ghc-9.12.1 as a build compiler Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant