Skip to content

Commit

Permalink
Add FIXMEs for future changes to commitment APIs.
Browse files Browse the repository at this point in the history
  • Loading branch information
dlongley committed Jan 10, 2025
1 parent e414f64 commit adc0758
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/bbs/blind/commitment.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {getCiphersuite} from '../ciphersuites.js';

// Note: This file uses naming conventions that match the IETF BBS RFCs.

// FIXME: rename to `CoreCommit`
export async function commit({
committed_messages, api_id, ciphersuite,
mocked_random_scalars_options
Expand Down Expand Up @@ -99,6 +100,8 @@ export async function commit({
commitment: C, proof, ciphersuite
});

// FIXME: consider passing in `secret_prover_blind` instead of generating
// it internally; or perhaps return object instead
return [commit_with_proof_octs, secret_prover_blind];
}

Expand Down Expand Up @@ -156,6 +159,7 @@ export function deserialize_and_validate_commit({
return commitment;
}

// FIXME: rename to `CoreCommitVerify`
export function verify_commitment({
commitment, commitment_proof, blind_generators,
api_id = new Uint8Array(), ciphersuite
Expand Down

0 comments on commit adc0758

Please sign in to comment.