Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to vc-v2-latest. #170

Merged
merged 3 commits into from
Aug 3, 2024
Merged

Updates to vc-v2-latest. #170

merged 3 commits into from
Aug 3, 2024

Conversation

davidlehn
Copy link
Member

No description provided.

@davidlehn davidlehn force-pushed the vc-v2-latest-updates branch from 2f5fbcc to b7974c9 Compare August 2, 2024 06:03
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving -- the error hit on the node 18 tests is not a new error, it comes up periodically and will need to be figured out in the future, not a concern for this PR or a new release.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (b258dd7) to head (b7974c9).

Additional details and impacted files
@@              Coverage Diff              @@
##           vc-v2-latest     #170   +/-   ##
=============================================
  Coverage         90.53%   90.53%           
=============================================
  Files                17       17           
  Lines              3170     3170           
=============================================
  Hits               2870     2870           
  Misses              300      300           
Files Coverage Δ
lib/CredentialStatusIssuer.js 89.93% <100.00%> (ø)
lib/issuer.js 93.42% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b258dd7...b7974c9. Read the comment docs.

@davidlehn davidlehn force-pushed the vc-v2-latest-updates branch from b7974c9 to 574fe16 Compare August 2, 2024 23:47
@davidlehn davidlehn merged commit b49bbb8 into vc-v2-latest Aug 3, 2024
5 checks passed
@davidlehn davidlehn deleted the vc-v2-latest-updates branch August 3, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants