Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 14 ci (require node >= 18) #160

Closed
wants to merge 5 commits into from
Closed

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Nov 28, 2023

Removes node 14 from the CI tests and sets node 18 as the lowest test and engine version.

p.s. node 14 is throwing this error when running the test suite:

file:///home/runner/work/vc/vc/node_modules/@digitalbazaar/ecdsa-multikey/lib/crypto.js:4
import {webcrypto} from 'node:crypto';
^^^^^^^^^
SyntaxError: The requested module 'node:crypto' does not provide an export named 'webcrypto'
at ModuleJob._instantiate (internal/modules/esm/module_job.js:124:21)
at async ModuleJob.run (internal/modules/esm/module_job.js:179:5)
at async Loader.import (internal/modules/esm/loader.js:178:24)
at async formattedImport (/home/runner/work/vc/vc/node_modules/mocha/lib/nodejs/esm-utils.js:9:14)
at async Object.exports.requireOrImport (/home/runner/work/vc/vc/node_modules/mocha/lib/nodejs/esm-utils.js:42:28)
at async Object.exports.loadFilesAsync (/home/runner/work/vc/vc/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
at async singleRun (/home/runner/work/vc/vc/node_modules/mocha/lib/cli/run-helpers.js:125:3)
at async Object.exports.handler (/home/runner/work/vc/vc/node_modules/mocha/lib/cli/run.js:370:5)

could be a duplicate of:
https://github.com/digitalbazaar/vc/pull/156/files

please note this could be a patch release as node 14 support is broken.

I am submitting this as a patch release as the current release is broken in node 14 and node 16 throws warnings on install and might have broken functionality not in the test suite.

@aljones15 aljones15 self-assigned this Nov 28, 2023
@aljones15 aljones15 changed the title Remove node 14 ci Remove node 14 ci (require node >= 16) Nov 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #160 (b4cc555) into main (d491d91) will decrease coverage by 0.22%.
Report is 22 commits behind head on main.
The diff coverage is 78.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   87.27%   87.05%   -0.22%     
==========================================
  Files           4        4              
  Lines         770      811      +41     
==========================================
+ Hits          672      706      +34     
- Misses         98      105       +7     
Files Coverage Δ
lib/index.js 87.19% <78.72%> (-0.27%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc17f2...b4cc555. Read the comment docs.

@aljones15 aljones15 changed the title Remove node 14 ci (require node >= 16) Remove node 14 ci (require node >= 18) Nov 28, 2023
@aljones15
Copy link
Contributor Author

closing as multiple PRs address this issue.

@aljones15 aljones15 closed this Nov 28, 2023
@JSAssassin JSAssassin deleted the remove-node-14-ci branch December 5, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants