Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend card #1430

Open
f1sh1918 opened this issue Apr 29, 2024 · 6 comments · May be fixed by #1749 or #1772
Open

Extend card #1430

f1sh1918 opened this issue Apr 29, 2024 · 6 comments · May be fixed by #1749 or #1772

Comments

@f1sh1918
Copy link
Contributor

f1sh1918 commented Apr 29, 2024

As a app user i want to be able to extend my card

Acceptance Criteria:

  • If a card is extendable the user will get a notification
  • the card is extendable if its expiry date is earlier than the endDate of the associated user entitlement
  • on click "extend" the user gets forwarded to the self service portal and the user data form will be prefilled

Technical Tasks:

  • add a notification area when a card is extendable
  • provide a link with queryParams to the self service portal
  • fill the form fields with the data in the queryParams
@f1sh1918 f1sh1918 added user story discussion-needed We need to resolve the questions in the issue. ui-ux koblenz labels Apr 29, 2024
@f1sh1918 f1sh1918 added this to the Koblenz Pass milestone Apr 29, 2024
@f1sh1918 f1sh1918 added the blocked Task or user story can not be continued at the moment label Jul 29, 2024
@f1sh1918 f1sh1918 removed the discussion-needed We need to resolve the questions in the issue. label Oct 2, 2024
@seluianova seluianova self-assigned this Oct 15, 2024
@f1sh1918
Copy link
Contributor Author

i talked to daniel and card extension via self service portal via link with query params is okay. We can just implement this

@seluianova
Copy link
Contributor

seluianova commented Oct 15, 2024

@hauf-toni hi! we would need your help here :)
could you propose how best to display a notification in the app that a card extension is available?
it is better to display the notification immediately after the application is launched (so - over the map), or when the Ausweisen tab is opened? how should the notification look like?

@f1sh1918 f1sh1918 removed the blocked Task or user story can not be continued at the moment label Oct 16, 2024
@seluianova seluianova added ui-ux and removed ui-ux labels Oct 28, 2024
@ztefanie ztefanie moved this to Next Up in team-app Nov 4, 2024
@seluianova seluianova moved this from Next Up to In Progress in team-app Nov 4, 2024
@seluianova seluianova linked a pull request Nov 6, 2024 that will close this issue
@seluianova seluianova linked a pull request Nov 6, 2024 that will close this issue
@hauf-toni
Copy link

You can find the design 📍 here.

@hauf-toni hauf-toni moved this to In Review in team-uiux 🎨 Nov 8, 2024
@seluianova
Copy link
Contributor

seluianova commented Nov 11, 2024

@hauf-toni thank you! I have a couple questions:

  1. the notification title seems to be missing in the design :)

  2. regarding the text "your card is about to expire".
    what if the card can be extended, but it expires in 1 year, for example. do we want to show this notification in such case?
    maybe we want to show it only when a card can be extended AND expire no later than in 3 month, or something like this?
    tagging @f1sh1918 @ztefanie if you have an opinion on that

  3. what would you recommend for the case, when the card has already expired?
    currently it looks like this:
    image
    we could pre-fill the form when a user clicks on "KoblenzPass beatragen oder verlängern", but is it necessary?
    the item says “beatragen ODER verlängern”, so what if a user wants to create a card with the new data, but a pre-filled form with the previous card's details will be opened and the user will have to clear it first. do you think it's fine?
    or do we need a different view for expired but extendable cards?

@ztefanie
Copy link
Member

  1. regarding the text "your card is about to expire".
    what if the card can be extended, but it expires in 1 year, for example. do we want to show this notification in such case?
    maybe we want to show it only when a card can be extended AND expire no later than in 3 month, or something like this?
    tagging @f1sh1918 @ztefanie if you have an opinion on that

I agree, this sounds like a good way to go 👍

  1. what would you recommend for the case, when the card has already expired?

I think for this issue of extending it seems fine. In general I think it would be nice, if expired cards are displayed differently, e.g. in grey, to make it clear at the first look, that they are expired.

we could pre-fill the form when a user clicks on "KoblenzPass beatragen oder verlängern", but is it necessary?
the item says “beatragen ODER verlängern”, so what if a user wants to create a card with the new data, but a pre-filled form with the previous card's details will be opened and the user will have to clear it first. do you think it's fine?
or do we need a different view for expired but extendable cards?

I think it would be nice to prefil the form, because a user may need to look up his/her reference number somewhere which is annoying, so just prefilling it seems fine, but I agree it should still be possible to edit the data in case the user wants to change something.

@hauf-toni
Copy link

  1. Agreed!
  2. I have added a design proposal for that case, see 📌 here.

@seluianova seluianova linked a pull request Nov 13, 2024 that will close this issue
@seluianova seluianova linked a pull request Nov 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Status: In Review
Status: No status
4 participants