#227 build basic backend deb package #228
Conversation
elKei24
force-pushed
the
227-deb-packages
branch
15 times, most recently
from
8864f1b
to
821b204
Compare
elKei24
force-pushed
the
227-deb-packages
branch
3 times, most recently
from
91d674a
to
cb6cdb9
Compare
elKei24
force-pushed
the
227-deb-packages
branch
from
cb6cdb9
to
72a660a
Compare
elKei24
force-pushed
the
227-deb-packages
branch
from
51f04dc
to
bed47c4
Compare
elKei24
force-pushed
the
227-deb-packages
branch
from
1460f69
to
f1076df
Compare
elKei24
force-pushed
the
227-deb-packages
branch
2 times, most recently
from
f8e20a5
to
e3c31a2
Compare
elKei24
force-pushed
the
227-deb-packages
branch
from
e3c31a2
to
bf00c12
Compare
| @@ -2,11 +2,9 @@ | |||
|
|
|||
| exposed_version=0.28.1 | |||
|
|
|||
| app.postgres.host=localhost | |||
| app.postgres.port=5432 | |||
| app.postgres.url=jdbc:postgresql://localhost:5432/ehrenamtskarte | |||
There was a problem hiding this comment.
didn't we have some problems with that?
There was a problem hiding this comment.
This is equivalent to the previous way. I no longer concat the url in java but pass the whole one here.
| if (!production) { | ||
| cfg.enableDevLogging() | ||
| cfg.enableCorsForAllOrigins() | ||
| cfg.addStaticFiles("/graphiql", "/graphiql", Location.CLASSPATH) | ||
| } |
There was a problem hiding this comment.
do we disable graphiql in production? I'd probably vote for having it enabled :D
There was a problem hiding this comment.
I think this is a tool for debugging and should not be exposed in production. Also you can always use intellij for sending graphql queries.
Not sure whether this tool is intended for production.
There was a problem hiding this comment.
To me, its just a public access to the api, which shouldn't do any harm...
There was a problem hiding this comment.
I see this more like a standalone application which could be deployed to production. I mean it is like the administration backend. I added it again because there is no problem from security perspective as these are just static files.
| <excludeFolder url="file://$MODULE_DIR$/backend" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/frontend" /> | ||
| </content> | ||
| <content url="file://$MODULE_DIR$" /> |
There was a problem hiding this comment.
Hmm... I think these changes should not be necessary....
There was a problem hiding this comment.
They also do not harm :) i tested this. No differnce with or without these changes.
|
|
||
| sub_filter_once off; | ||
| sub_filter_types application/json; | ||
| sub_filter "https://tiles.staging.ehrenamtskarte.app" "http://localhost:5002"; |
There was a problem hiding this comment.
is that right for development?
There was a problem hiding this comment.
Seems right. It gets replaced with localhost like before.
docker/reverse_proxy/www/map.html
Outdated
| <body> | ||
| <div id='map' style='width: 100%; height: 100%;'></div> | ||
| <script> | ||
| mapboxgl.accessToken = 'pk.eyJ1IjoibWF4YW1tYW5uIiwiYSI6ImNraHlzdGNmejBkaGsycm9hNjJjcWZzdmwifQ.3NaekT5CjDsBnBNdUr1F7g'; |
There was a problem hiding this comment.
Noopsie just an alreadly public key which is not used. Dummy key.
|
Can be merged from my side. |
|
I merged this now, for the rest we should create separate tasks |
Does not close issue #227 yet, but is a working intermediate step and prevents all other PRs from getting red.
Builds a basic .deb package containing the built backend and a systemd service file for starting it.