-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2520: Show number search results #2976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, definitely going in the right direction already and working as expected 🎉
I added a few minor comments, please have a look at styled components.
Implementing this for native is still missing, let me know if you feel comfortable addressing this already, otherwise I can also take over.
One additional thing: We tend to add release notes for issues that are user facing to improve our store presence. Could you please add one for this change? Have a look here: https://github.com/digitalfabrik/integreat-app/blob/main/docs/contributing.md#release-notes
JFYI: The fact that the build is failing is not your fault, to avoid this, simply rebase your branch to main or merge main into your branch. Can also be done at a later point though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. 🚀
Tested on Web and Android, looks already really good. 👍
I just added some small comments that should be easy to fix.
release-notes/unreleased/2520-Show-number-of-search-results.yml
Outdated
Show resolved
Hide resolved
Thank you for the review 🌸 I think i resolved all issue suggestions :)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you for the adjustments. Looks good 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks great. Tested on firefox and real android, works as expected 😍
You still have to run prettier as this fails the checks (the formatting in the release note is somehow off):
yarn prettier:write
One other thing: The ticket also mentions to add this to the city search (i.e. http://localhost:9000/landing/de) on both web and native, could you still add the same functionality there? If not, thats okay as well, then we can just do a separate PR for it.
release-notes/unreleased/2520-Show-number-of-search-results.yml
Outdated
Show resolved
Hide resolved
This reverts commit 6305659
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks great! Tested on firefox and android
Short description
Show the amount of search results
Proposed changes
Side effects
None.
Testing
Check css styling
Resolved issues
Fixes: #2520