3029: Add typing indicator for automatic replies in chat #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunars97
requested review from
steffenkleinle,
f1sh1918,
LeandraH and
bahaaTuffaha
as code owners
lunars97
force-pushed
the
3029-add-typing-indicator-for-automatic-replies
branch
from
50de658 to
2a08823
Compare
lunars97
force-pushed
the
3029-add-typing-indicator-for-automatic-replies
branch
from
2a08823 to
529d718
Compare
lunars97
changed the title
|
The typing indicator also appearing before the automatic reply, I have no idea how to limit this behaviour... Any ideas? |
steffenkleinle
requested changes
Jan 29, 2025
|
Also see my question here: #3029 (comment) |
steffenkleinle
approved these changes
Jan 31, 2025
Comment on lines
43
to
44
| const showIndicatorOfTyping = | ||
| messages[messages.length - 1]?.userIsAuthor || messages[messages.length - 2]?.userIsAuthor |
There was a problem hiding this comment.
This means that if the message before the last one is a user it will show the 3 dot.
Shouldn't be shown just if the last message is coming from a user?
There was a problem hiding this comment.
Fair point and I think you are right. Seems like I was a little tired already when I made my review, sorry :D Probably we would need a condition in the following way:
Show the indicator if either
- the last message was sent by the user OR
- there is only one message yet that was NOT sent by the user (as that is the automatic answer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Typing indicator message (...) for 60 seconds should be shown after automatic answer in chat. It will be a temporary solution untill the websocket implementation
Proposed changes
Side effects
Resolved issues
Fixes: #3029