3112: Prevent unnecessary tts stop #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
requested review from
f1sh1918,
LeandraH,
bahaaTuffaha and
lunars97
as code owners
f1sh1918
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Looks like your changes crashed sth on ios. On main everything works fine.
Tested on ios simulator (ios 18.0)
If i click play it reads only the headline and shows "nichts zu lesen" and stops
Guess the updateSentence is broken somehow
Simulator.Screen.Recording.-.iPhone.16.-.2025-02-20.at.10.54.27.mp4
Same for Andorid it just stops with nothing to read... |
… to fix breaking language change
steffenkleinle
force-pushed
the
3112-tts-stop
branch
from
5338043 to
3e96eeb
Compare
bahaaTuffaha
approved these changes
Feb 20, 2025
f1sh1918
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Prevent unnecessary tts stop causing errors if no tts engine installed.
Proposed Changes
Side Effects
I thought of preventing sending a sentry stacktrace for known issues (such as this one), but decided against as it still might be helpful to detect issues such as this one. However, we will continue to get this error for people that try to open the tts player but dont have a tts player installed.Due to the unexpected behavior on language change described below, I reverted the previous changes and ignore the error instead.Testing
Not sure how to test this. Have a degoogled android phone I guess. Or just throw an error in
stopand ensure that it is not called without actually opening the tts function.Resolved Issues
Fixes: #3112