Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behaviour of imprint feedback #1360

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

ulliholtgrave
Copy link
Member

Short description

This PR fixes two issues with a non existing imprint.

Resolved issues

Fixes: #1289
Fixes: #1359

@ulliholtgrave ulliholtgrave requested a review from a team as a code owner April 15, 2022 14:54
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this fixes our issues with the imprint feedback! 💪 🎉

integreat_cms/api/v3/feedback/imprint_page_feedback.py Outdated Show resolved Hide resolved
integreat_cms/api/v3/feedback/imprint_page_feedback.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ulliholtgrave ulliholtgrave force-pushed the bugfix/feedback_api branch 2 times, most recently from 3ebc0b9 to 9092471 Compare April 15, 2022 16:54
@codeclimate
Copy link

codeclimate bot commented Apr 15, 2022

Code Climate has analyzed commit b83d0c2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 70.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.1% (0.0% change).

View more on Code Climate.

@ulliholtgrave ulliholtgrave force-pushed the bugfix/feedback_api branch 2 times, most recently from 06d0fb4 to cacb3f8 Compare April 15, 2022 17:06
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 👍

@ulliholtgrave ulliholtgrave merged commit f184eb0 into develop Apr 15, 2022
@ulliholtgrave ulliholtgrave deleted the bugfix/feedback_api branch April 15, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imprint deletion breaks feedback list Submitting imprint page feedback breaks region feedback list
2 participants