This repository has been archived by the owner on Sep 30, 2021. It is now read-only.
Fix overjump of entries #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ouch, classic mistake. Thanks a lot! I'll merge this when I have a moment to test the revised version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug which shrinks the scraped results down to the floored half amount of results. E.g. for an Instagram channel with 75 entries, only 37 results are scraped. This is due to the double access of the Iterator "chunk": by using access for looping through the Iterator, and by using the next() function, the Iterator drops 2 items instead of 1. This way, only every second result gets scraped. I resolved it by using the for-loop's iterator from the Iterator item instead of calling next().