cherry-picks from upstream to fix conformance test #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit updates the service logic, from the agent all the way down to the datapath, to take into account the L4 protocols specified in a k8s service. Historically Cilium has always been ignoring, at least from a end user perspective, the protocol specified in a k8s service, resulting in the inability to expose a port only for a given protocol, or in the opposite case, resulting in a single protocol-agnostic service exposed whenever 2 TCP and UDP services on the same port were configured. Co-authored-by: Nate Sweet <[email protected]> Co-authored-by: Antonio Ojea <[email protected]> Signed-off-by: Gilberto Bertin <[email protected]>
add a new bpf-lb-proto-diff flag that disables the service protocol differentiation logic, allowing to keep the old Cilium behavior where service protocols are not distinguished Signed-off-by: Gilberto Bertin <[email protected]>
when upgrading to a version of Cilium that supports and has service protocol differentiation enabled, existing services without protocol set will be overwritten (or better, restored from the bpf maps, deleted because they are orphan and the recreated) with their protocol set. As this causes connection disruptions, keep those services without protocol until the user explicitly deletes them. To allow both type of services to co-exist, this commit: - introduces a second service lookup in the datapath, without the protocol set, in case the protocol lookup fails - updates the service allocation logic to check both for services with and without protocol before allocating a new one - updates the deletion logic to look for both with and without protocol versions, to ensure all service versions are proper deleted Co-authored-by: Antonio Ojea <[email protected]> Signed-off-by: Gilberto Bertin <[email protected]>
Signed-off-by: Gilberto Bertin <[email protected]>
dhij
changed the title
There is no use case that I can think of right now, but will be handy to use it in Gateway API unit tests. Signed-off-by: Tam Mach <[email protected]>
…tion Co-authored-by: Antonio Ojea <[email protected]> Signed-off-by: Gilberto Bertin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cilium#33434 fix for the issue described in cilium#9207 will not be backported to older versions. So we would like to cherry-pick the upstream changes on the version we support now
v1.14.10.cilium#33434 has 8 commits but the cherry-picks don't include all of them.
The major merge conflicts happened in pkg/k8s/watchers/service.go
v1.14has the service related methods inpkg/k8s/watchers/watcher.goex) addK8sSVCs and delK8sSVCs whereas upstream has moved the service related methods toservice.gofile and extractedk8sServiceManager