Add error handling #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Any updates on this? It was confusing when response was |
| @@ -64,7 +64,7 @@ def retrieve(page, per_page = self.per_page) | |||
| invoker = ResourceKit::ActionInvoker.new(action, resource, *@args) | |||
| invoker.options[:per_page] ||= per_page | |||
| invoker.options[:page] = page | |||
|
|
|||
| # require 'pry'; binding.pry | |||
There was a problem hiding this comment.
Extra debug comment leftover?
|
👍, just a couple of small comments. |
phillbaker
force-pushed
the
feature/errors
branch
from
696baec
to
75c9ae8
Compare
This handles non 200-299 responses by all resources with specific errors, where necessayr and default handlers.
phillbaker
force-pushed
the
feature/errors
branch
from
75c9ae8
to
9316989
Compare
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles non 200-299 responses by all resources with specific errors, where necessary and default handlers.
Addresses #59 and the rest of #1.
cc @nanzhong