Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spaces Key API #958

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add Spaces Key API #958

wants to merge 14 commits into from

Conversation

lee-aaron
Copy link

OBJECT-6022

This adds information about the Spaces Key API to the OpenAPI spec.

I can add a [Beta] tag somewhere if needed as users would need to be on the flipper to access this!

@lee-aaron lee-aaron force-pushed the alee/keys-api branch 2 times, most recently from 2749a98 to 926ae10 Compare January 6, 2025 20:07
andrewsomething
andrewsomething requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I did leave a few comments in-line. Let me know if you have any questions about them.

andrewsomething
andrewsomething requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌 A couple tiny changes needed for the update response bodies.

@lee-aaron @andrewsomething
Apply suggestions from code review
79b0cb6 
Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
@loosla loosla requested a review from andrewsomething January 9, 2025 13:35
@andrewsomething andrewsomething self-assigned this Jan 9, 2025
@lee-aaron lee-aaron mentioned this pull request Jan 10, 2025
Merged
@lee-aaron lee-aaron mentioned this pull request Jan 17, 2025
Open
@lee-aaron lee-aaron mentioned this pull request Jan 22, 2025
Open
@dbrian57 dbrian57 self-assigned this Feb 20, 2025
dbrian57
dbrian57 requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@dbrian57 dbrian57 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aaron, all of the feedback here is minor stuff. I reworded some things to be more active and less circular. There are a few questions in here, too. Please ping me when you're done for a quick re-review. Thanks!

@lee-aaron lee-aaron force-pushed the alee/keys-api branch 3 times, most recently from 7bcedff to 4175ea0 Compare February 25, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrian57 dbrian57 dbrian57 requested changes

@andrewsomething andrewsomething Awaiting requested review from andrewsomething

Requested changes must be addressed to merge this pull request.

Assignees

@andrewsomething andrewsomething

@dbrian57 dbrian57

Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lee-aaron @andrewsomething @dbrian57 @danaelhe @loosla