Skip to content

Commit

Permalink
fix HELLO, set RESP default buffer size with 2048
Browse files Browse the repository at this point in the history
  • Loading branch information
diiyw committed Jan 7, 2025
1 parent 44beaa6 commit fac7ca5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
3 changes: 2 additions & 1 deletion handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ func cmdNotFound(n *Nodis, conn *redis.Conn, cmd redis.Command) {

func hello(n *Nodis, conn *redis.Conn, cmd redis.Command) {
execCommand(conn, func() {
conn.WriteArray(13)
conn.WriteArray(14)
conn.WriteBulk("server")
conn.WriteBulk("redis")
conn.WriteBulk("version")
Expand All @@ -303,6 +303,7 @@ func hello(n *Nodis, conn *redis.Conn, cmd redis.Command) {
conn.WriteBulk("role")
conn.WriteBulk("master")
conn.WriteBulk("modules")
conn.WriteArray(0)
})
}

Expand Down
3 changes: 1 addition & 2 deletions nodis.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,7 @@ func (n *Nodis) Serve(addr string) error {
os.Exit(0)
}()
return redis.Serve(addr, func(conn *redis.Conn, cmd redis.Command) {
c := GetCommand(cmd.Name)
c(n, conn, cmd)
GetCommand(cmd.Name)(n, conn, cmd)
if conn.HasError() && conn.State != 0 {
conn.State |= redis.MultiError
}
Expand Down
2 changes: 1 addition & 1 deletion redis/resp.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type Reader struct {
cmd Command
}

const defaultSize = 4096
const defaultSize = 2048

func NewReader(rd io.Reader) *Reader {
return &Reader{
Expand Down

0 comments on commit fac7ca5

Please sign in to comment.