Adding cat operator kernel optimization #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dijopaul
reviewed
Oct 23, 2024
| if (all_1d_empty) { | ||
| return out; | ||
| } | ||
|
|
There was a problem hiding this comment.
should we insert optimized coder here ?
Do we support dim < 0 or all_1d_empty cases ?
There was a problem hiding this comment.
We support for dim < 0. For all_1d_empty cases, we don't have check for that or a separate conditionalized code, it will go through the general flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated xa_nn_concat_32_32 kernel optimization for cat operator