Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding minimum, maximum and clamp operators #24

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Adding minimum, maximum and clamp operators #24

merged 4 commits into from
Oct 23, 2024

Conversation

nishpoonia
Copy link
Collaborator

Adding minimum, maximum and clamp operators

@dijopaul dijopaul changed the base branch from main to main_test October 18, 2024 09:29
dijopaul
dijopaul approved these changes Oct 23, 2024
View reviewed changes
backends/cadence/hifi/operators/op_maximum.cpp
});
}

return out;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think wwe need to return from if and no else

backends/cadence/hifi/operators/op_minimum.cpp Show resolved Hide resolved
@dijopaul dijopaul merged commit 813e6c1 into main_test Oct 23, 2024
1 of 4 checks passed
@nishpoonia nishpoonia deleted the nishak_clamp branch November 28, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dijopaul dijopaul dijopaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nishpoonia @dijopaul