Adding cat, full, permute_copy and relu ops #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dijopaul
reviewed
Nov 14, 2024
| @@ -60,7 +60,7 @@ | |||
| - op: full.out | |||
| kernels: | |||
| - arg_meta: null | |||
| kernel_name: torch::executor::full_out | |||
| kernel_name: impl::HiFi::full_out | |||
There was a problem hiding this comment.
use name space cadence::impl::HiFi::
| @@ -85,7 +85,7 @@ | |||
| - op: permute_copy.out | |||
| kernels: | |||
| - arg_meta: null | |||
| kernel_name: torch::executor::permute_copy_out | |||
| kernel_name: impl::HiFi::permute_copy_out | |||
There was a problem hiding this comment.
use name space cadence::impl::HiFi::
|
|
||
| constexpr auto name = "full.out"; | ||
|
|
||
| bool optimized = 0; |
|
|
||
| bool optimized = false; | ||
|
|
||
| if (out.scalar_type() == ScalarType::Float) |
| num_out_dims, | ||
| num_inp_dims); | ||
|
|
||
| return out; |
There was a problem hiding this comment.
why we need return here I think there is return common to all if else
| (int)255, | ||
| input.numel()); | ||
| ret_val = 5; | ||
|
|
dijopaul
added a commit
that referenced
this pull request
Nov 28, 2024
* Adding cat, full, permute_copy and relu ops (#34) * Adding cat, full, permute_copy * updating relu wrt new ref (#36) * Temporary memory allocation, replacing mallocs (#38) * Integrated temporary mem alloc functionality in place of malloc * Namespace related changes * Cleanup the main application * Adding atan2, softmax, clamp and remainder ops (#37) * Replaced malloc with temp_memory_allocator --------- Co-authored-by: nishpoonia <[email protected]> Co-authored-by: Rushi-cad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding cat, full, permute_copy and relu ops