Several improvements and fixes #14
Conversation
guicamest
commented
Mar 19, 2018
guicamest
commented
- Reduce lines read from cec-client
- Faster conflicting process checking
- Some cec keys are not emitted
- Don't break if lines in retroarch are in different order
- Allow remote key repeats (by holding them down)
- Allow configuration of cec mappings via cfg file
|
Hi @Forceu ! Glad you liked it. I've been using it for a few days now and so far no problems. |
|
I meant the function in line 117 of your PR If an unknown key like "non-standard-key" is found (instead of eg. "enter" or "f1"), it would call the function get_keymap. However you replaced get_keymap() with get_keyboard_to_uinput_map(). @dillbyrne is this project still maintained? If not, I forked it and incorporated the PRs: https://github.com/Forceu/es-cec-input |
|
Hi @guicamest @Forceu . Thanks for the PRs 👍 . I won't have a chance until sometime next week to test the PRs as I'm away from the TV / Pi. I'll merge them then if there are no issues. |
|
@Forceu Thanks for pointing that out! Just pushed a fix for it. |
|
Hey @dillbyrne , did you have a time to look at this? |
|
Hi @guicamest the proposed changes add too much cpu overhead considering the specs of the pi. Considering what the script does, it should only use very little cpu and only when it is in use. htop output script without changes memory is 0.9 script with proposed changes memory is 0.9 I would look at the main loop and subprocess code as it is running in kodi when it shouldn't be. This means that it will be adding ~9% overhead in emulators too which we obviously can't have. |
|
I can confirm that I have the same behaviour on my Pi. I first thought it was related to the Wifi AP I added, but came to the conclusion that it is actually the script. My Pi heated up to 82°C in idle. |
|
I didn't notice anything unusual about cpu usage but I'll take a look at it again. Thanks for the insight! |
* Reduce lines read from cec-client
* Faster conflicting process checking
* Some cec keys are not emitted
* Don't break if lines in retroarch are in different order
* Allow remote key repeats (by holding them down)
* Allow configuration of cec mappings via cfg file
|
@dillbyrne @Forceu Found the issue! In other to process keys as they are pressed in the remote, the loop was invoked every 0.002 seconds, therefore it made a lot of calls to ps(to check running processes). To avoid that a sleep would do, but we'd be missing the ability to process keys as they are pressed in the remote. |
|
@dillbyrne @Forceu any updates? |
es-cec-input.py
Outdated
| with open(ra_cfg, 'r') as fp: | ||
| for line in fp: | ||
| <<<<<<< 9ea7e255376d2db0c22efcedfa097b5a640977fd |
There was a problem hiding this comment.
There is a conflict starting this line @guicamest
There was a problem hiding this comment.
Thanks for the heads up @paradadf ! It's been like this for more than a year... :|
Already fixed it and updated :)
There was a problem hiding this comment.
@guicamest, I wanted to contact you about other things in this improvements you did but couldn’t find a way. Are somewhere on discord or how could I write you a line? (Sorry, I know this isn’t the place)
There was a problem hiding this comment.
Feel free to comment on the relevant commit: https://github.com/guicamest/es-cec-input/commits/pressed
