Skip to content

Commit

Permalink
ci: headless e2e
Browse files Browse the repository at this point in the history
  • Loading branch information
qzeene committed Jul 13, 2023
1 parent 6e052b6 commit 30e3299
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
name: pull-request
on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]

Expand All @@ -20,6 +18,8 @@ jobs:
tests:
runs-on: ubuntu-latest
needs: lint
env:
CI: true
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand All @@ -28,9 +28,9 @@ jobs:
- name: Install deps
run: npm ci
- name: Run unit tests
run: CI=true npm run test
run: npm run test
- name: Install Playwright Browsers
run: npx playwright install --with-deps
run: npx playwright install chromium --with-deps
- name: Run Playwright tests
run: npm run e2e
- uses: actions/upload-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const config: PlaywrightTestConfig = {
/* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
trace: "on-first-retry",

headless: false,
headless: !!process.env.CI,
},

/* Configure projects for major browsers */
Expand Down

0 comments on commit 30e3299

Please sign in to comment.