Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire user permissions #72

Merged
merged 18 commits into from
Nov 10, 2024
Merged

Expire user permissions #72

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
837b5f4
refactor: setup for multiple hooks
mkangia Nov 1, 2024
28815f5
refactor: extract test utils & login mixin; isort
mkangia Nov 1, 2024
011ebda
track role syncing timestamp
mkangia Nov 1, 2024
df017ea
isort
mkangia Nov 1, 2024
3622bbf
resync domain role after expiry
mkangia Nov 1, 2024
b437aba
refactor: move constants to const;isort
mkangia Nov 1, 2024
764d677
refactor: expand imports;isort
mkangia Nov 1, 2024
2d002ca
fix flaky test
mkangia Nov 1, 2024
e678353
ensure logout after each test
mkangia Nov 1, 2024
716651c
add domain independent call
mkangia Nov 1, 2024
c8111d4
refactor; remove duplicate import
mkangia Nov 1, 2024
7ef5429
correct function name
mkangia Nov 4, 2024
a195929
return error message if syncing fails
mkangia Nov 4, 2024
b4eb1b3
add log requests to domain excluded views to ignore in hooks
mkangia Nov 4, 2024
a5f2c58
avoid sync conflicts
mkangia Nov 4, 2024
e92b419
Merge branch 'cs/SC-3473-user-roles-from-hq' into mk/3475-expire-user…
mkangia Nov 4, 2024
e98e66b
Merge branch 'cs/SC-3473-user-roles-from-hq' into mk/3475-expire-user…
Charl1996 Nov 6, 2024
da46257
update error message to highlight possible access revoke
mkangia Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hq_superset/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def _do_assert(datasources):
client.get('/hq_datasource/list/', follow_redirects=True)
_do_assert(self.oauth_mock.test2_datasources)

@patch.object(DomainSyncUtil, "sync_domain_role", return_value=True)
@patch.object(DomainSyncUtil, "_get_domain_access", return_value=({"can_write": True, "can_read": True}, []))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what the issue was here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a flaky test that succeeded when run separately or if only this test file was run but failed when the full test suite was run.
I believe the permissions were getting set unexpectedly or getting revoked somehow, so I set them specifically instead of skipping it via the patch for sync_domain_role. I did try to debug it for a couple of hours before letting it be.

def test_datasource_upload(self, *args):
client = self.app.test_client()
self.login(client)
Expand Down