Reuse maintenance window check for formplayer deploys #6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gherceg
commented
Dec 21, 2023
| @@ -1,8 +1,6 @@ | |||
| import shlex | |||
| from datetime import datetime, timedelta | |||
|
|
|||
| import pytz | |||
There was a problem hiding this comment.
pytz is already imported in deploy/utils.py if you happen to notice that there isn't a diff adding it to the file.
dannyroberts
approved these changes
Jan 24, 2024
millerdev
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deployed formplayer at a non ideal time, and realized the existing maintenance window check we have for commcare deploys is not used for formplayer. This PR reuses that code for formplayer deploys as well.
Tested on production:
Environments Affected
None