-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes for ansible upgrade 9.1.0 #6209
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,7 +141,7 @@ | |
- name: check users password valid time | ||
shell: getent shadow "{{ item }}" | cut -d':' -f5 | ||
register: users_pw_valid | ||
loop: "{{ dev_users.present }} + ['ansible', '{{ cchq_user }}']" | ||
loop: "{{ ['ubuntu'] + ['ansible', cchq_user] }}" | ||
changed_when: False | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. change this to loop: "{{ ['dev_users.present'] + ['ansible', cchq_user] }}" |
||
|
||
- name: clear users password valid time | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,13 +83,13 @@ | |
tags: | ||
- es_conf | ||
|
||
- include: misc_v2.yml | ||
- include_tasks: misc_v2.yml | ||
when: elasticsearch_version == '2.4.6' | ||
|
||
- include: misc_v5.yml | ||
- include_tasks: misc_v5.yml | ||
when: elasticsearch_version == '5.6.16' | ||
|
||
- include: misc_v7.yml | ||
- include_tasks: misc_v7.yml | ||
when: elasticsearch_version is version('7.0.0', '>=') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. include_tasks:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not totally clear whether To summarize, this looks fine unless Ansible doesn't like it for some reason. |
||
|
||
- name: Copy Elasticsearch Systemd Conf | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
--- | ||
- include: install_agent.yml | ||
- include_tasks: install_agent.yml | ||
tags: lpar2rrd_agent | ||
- include: install_master.yml | ||
- include_tasks: install_master.yml | ||
when: inventory_hostname in groups.lpar2rrd_master|default([]) | ||
tags: lpar2rrd_master |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,7 @@ | |
tags: pghashlib | ||
|
||
- name: Setup plproxy | ||
include: plproxy.yml | ||
include_tasks: plproxy.yml | ||
when: item.get('host') | ||
loop: | ||
- "{{ postgresql_dbs.form_processing.proxy|default({}) }}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. include_tasks I've replaced the include statement with include_tasks since it seems that the file plproxy.yml contains tasks. |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
--- | ||
- include: install_latest.yml | ||
- include_tasks: install_latest.yml | ||
when: rabbitmq_version == '3.10.13-1' | ||
|
||
- include: install_old.yml | ||
- include_tasks: install_old.yml | ||
when: rabbitmq_version == '3.10.7-1' | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. include_tasks
|
||
- name: Place config file | ||
|
@@ -40,19 +40,19 @@ | |
become: yes | ||
service: name=rabbitmq-server state=started | ||
|
||
- include: config-cluster.yml | ||
- include_tasks: config-cluster.yml | ||
when: rabbitmq_create_cluster|bool | ||
|
||
- include: config.yml | ||
- include_tasks: config.yml | ||
when: not rabbitmq_create_cluster or ( ansible_fqdn == hostvars[rabbitmq_cluster_master]['ansible_fqdn'] ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. include_tasks
|
||
|
||
- name: Enable and start RabbitMQ service | ||
become: yes | ||
service: name=rabbitmq-server state=started | ||
tags: after-reboot | ||
|
||
- include: join-cluster.yml | ||
- include_tasks: join-cluster.yml | ||
when: (rabbitmq_create_cluster | bool) and ( ansible_fqdn != hostvars[rabbitmq_cluster_master]['ansible_fqdn'] ) | ||
|
||
- include: ha-policy.yml | ||
- include_tasks: ha-policy.yml | ||
when: (rabbitmq_create_cluster| bool ) and ( ansible_fqdn == hostvars[rabbitmq_cluster_master]['ansible_fqdn'] ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. include_tasks
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
--- | ||
|
||
- include: setup_cluster.yml | ||
- include_tasks: setup_cluster.yml | ||
when: is_redis_cluster|bool and inventory_hostname in groups['redis_cluster_master'] | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. include_tasks
|
||
- name: start the redis service | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
- include: sentry.yml | ||
- include_tasks: sentry.yml | ||
tags: sentry | ||
- include: clickhouse.yml | ||
- include_tasks: clickhouse.yml | ||
tags: clickhouse | ||
- include: snuba.yml | ||
tags: snuba | ||
- include_tasks: snuba.yml | ||
tags: snuba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look like it does what it did before. Would this work instead?