Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy stack improvements #6456

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Deploy stack improvements #6456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bda3c4
resolve warning for no_log
mkangia Dec 27, 2024
6258bdc
add retries to account for restart/delays
mkangia Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/commcare_cloud/ansible/roles/couchdb2/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
- meta: flush_handlers

- name: Add nodes
no_log: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this resolves the warning
[WARNING]: Module did not set no_log for password

uri:
url: "http{% if couchdb_secure %}s{% endif %}://{{ inventory_hostname|ipaddr }}:{% if couchdb_version is version('3.0.0', '>=') %}{{ couchdb_port }}/_node/_local{% else %}{{ couchdb_node_port }}{% endif %}/_nodes/couchdb@{{ item|ipaddr }}"
method: PUT
Expand All @@ -91,6 +92,10 @@
status_code: 201, 409 # 409 means already set up (conflict)
body: '{}'
when: inventory_hostname == groups.couchdb2.0 and item != groups.couchdb2.0
register: result
until: not result.failed or 'Connection refused' not in result.msg
retries: 5
delay: 10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from the retry configuration in the following task. Though chosen a shorter waiting time since 20 seconds seemed a bit of overkill.

with_items: "{{ groups.couchdb2 }}"
tags:
- add_couch_nodes
Expand Down
Loading