[USH-4025] Add waf_allow to EditBasicProjectInfoView #34017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akashkj for dimagi/commcare-cloud#6210 to be merged, this one has to be reviewed and merged as well. Can you clean up this PR? I'm going to convert it to "draft" which is our standard status for changeset you're intending to PR soon but that doesn't yet meet the basic formal standards for a PR. |
akashkj
added
the
product/all-users-all-environments
|
@dannyroberts I have modified the url to include |
orangejenny
approved these changes
Jan 29, 2024
dannyroberts
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Currently some of the image upload in project settings result in 403 forbidden due to metadata attached to it. Adding a WAF rule to allow such requests.
Technical Summary
https://dimagi-dev.atlassian.net/browse/USH-4025
From WAF logs in Athena, getting
XBODY_XSSblocking -[{conditiontype=XSS, location=BODY, matcheddata=[<?, ]}]Feature Flag
NA
Safety Assurance
Safety story
https://confluence.dimagi.com/pages/viewpage.action?spaceKey=saas&title=How+traffic+gets+to+our+system%3A+Global+Accelerator%2C+ALB%2C+and+WAF
To be tested on staging
Automated test coverage
NA
QA Plan
NA
Migrations
NA
Rollback instructions
Labels & Review