Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit new endpoint to limit locations when creating new mobile workers #34964

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

AddisonDunn
Copy link
Contributor

@AddisonDunn AddisonDunn commented Aug 9, 2024

Product Description

Fixes QA-6985.

USH feature epic: link.

Original related PR: link.

Technical Summary

The form to create mobile workers is not using the LocationSelectWidget, and was hitting the old, location_search endpoint.

Feature Flag

Technically the code isn't behind a FF, but in order for locations to be limited in the dropdown a project would need to turn on the LOCATION_HAS_USERS and configure locations in accordance with this feature.

Safety Assurance

Safety story

  • Tested locally, looks good
  • This endpoint has been tested thoroughly by QA

Automated test coverage

This endpoint is tested in corehq/apps/locations/tests/test_views.py

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@AddisonDunn AddisonDunn requested a review from Jtang-1 August 9, 2024 14:18
@AddisonDunn AddisonDunn added the product/all-users-all-environments Change impacts all users on all environments label Aug 9, 2024
@AddisonDunn AddisonDunn marked this pull request as ready for review August 9, 2024 14:35
@AddisonDunn AddisonDunn requested a review from esoergel as a code owner August 9, 2024 14:35
Copy link
Contributor

@Jtang-1 Jtang-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, could you also add in the description a link to your original PR that introduced this endpoint?

@AddisonDunn
Copy link
Contributor Author

Sure

@AddisonDunn AddisonDunn merged commit 3f78fc6 into master Aug 13, 2024
13 checks passed
@AddisonDunn AddisonDunn deleted the ad/limit-locations-create-mobile-worker branch August 13, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/all-users-all-environments Change impacts all users on all environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants