Use QuillJS as rich text editor #35695
Conversation
MartinRiese
force-pushed
the
riese/quill
branch
3 times, most recently
from
497069a to
5b66b0c
Compare
MartinRiese
force-pushed
the
riese/quill
branch
from
5b66b0c to
f0cef00
Compare
* And some cosmetic changes * Still need to figure out where to put the styles
* Move toolbar into template to make it customizable
MartinRiese
force-pushed
the
riese/quill
branch
from
860894f to
d94063b
Compare
dimagimon
added
the
Risk: Medium
* Started working for some reason now.
This reverts commit ddeffd0.
* sadly adding it to the content function did not work so I had to list them out * also add rounded corners
* Using the ql-image class overrode the eventlistener * Using the handler is cleaner and allow us to extract the handler function
| input.click(); | ||
| } | ||
|
|
||
| ko.bindingHandlers.richEditor = { |
There was a problem hiding this comment.
we can use alpine js on HQ now. Can you please consider looking at ways to extend alpine as an alternative to creating a new knockout binding handler? This is creating more future tech debt, and I really want to discourage this
There was a problem hiding this comment.
That is fair. I had not even thought about alpine without htmx. Is there another place where we use it in this way, that I can have a look at?
| import ko from "knockout"; | ||
|
|
||
| import "quill/dist/quill.snow.css"; | ||
| import "hqwebapp/js/components/quill.css"; |
There was a problem hiding this comment.
i find it strange that a component's css is living in the js folder
There was a problem hiding this comment.
Originally I had the binding in corehq/messaging/scheduling/static/scheduling/js/create_schedule.js and webpack would not find the css file in corehq/messaging/scheduling/static/scheduling/css and I could not figure out why. Let me try not that it is n hqwebapp
There was a problem hiding this comment.
I don't know what I am doing wrong. If you can tell me how to reference it once moved I am happy to do it.
Product Description
Use QuillJs for rich text editing since its license works out well for us.
Technical Summary
Feature Flag
rich_text_emails
Safety Assurance
Safety story
Automated test coverage
QA Plan
Rollback instructions
Labels & Review