Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that CollidingEntities requires ActiveEvents::COLLISION_EVENTS #451

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Conversation

daboross
Copy link
Contributor

Looks like this may not have been the case before. I ran into this trying to use CollidingEntities, and was only able to find the cause after looking into its implementation.

Lmk if anything else is needed for this PR!

Looks like this may not have been the case before. I ran into this trying to use CollidingEntities, and was only able to find the cause after looking into its implementation.
Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sebcrozet sebcrozet merged commit c6bcce4 into dimforge:master Dec 10, 2023
3 checks passed
@sebcrozet
Copy link
Member

Thanks!

@daboross daboross deleted the patch-1 branch December 10, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants