Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sort the years ascending. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

runephilosof
Copy link

It makes more sense to have the newest years first instead of having the user scroll down the page to find the newest.
Also, it avoids wasting time on unnecessary sorting.

It makes more sense to have the newest years first instead of having the user scroll down the page to find the newest.
Also, it avoids wasting time on unnecessary sorting.
@cableman
Copy link
Member

cableman commented Mar 5, 2013

This change have to be 'approved' by the ding team before merging. I have sent a mail to them :-)

@runephilosof
Copy link
Author

I have been asked to specify exactly what this changes.
I have attached a screenshot from http://ding2tal.ting.dk/ting/object/775100%3A03200442 showing the years being sorted in the wrong order.
bug ding_periodical_year_sort

@gBarlach
Copy link

gBarlach commented Mar 8, 2013

A usefull change. Hereby approved by the ding team

@xendk
Copy link
Contributor

xendk commented Oct 17, 2015

Sorry, removing the sorting is not the right solution. If ding_periodical doesn't sort the list, you'll have to ensure that all existing and future providers sort the volumes the right way.

ding_periodical should sort the volumes to the desired order to ensure consistency, that's why it's doing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants