Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Optimism, Base, Metis and Avalanche #25

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Support Optimism, Base, Metis and Avalanche #25

merged 2 commits into from
Oct 16, 2023

Conversation

Jeff-CCH
Copy link
Contributor

@Jeff-CCH Jeff-CCH commented Oct 12, 2023 •
edited
Loading

  • add network info
  • yarn changeset

hihiben
hihiben reviewed Oct 13, 2023
View reviewed changes
src/logics/aave-v3/configs.ts Show resolved Hide resolved
src/logics/compound-v3/configs.ts Show resolved Hide resolved
src/logics/paraswap-v5/configs.ts Show resolved Hide resolved
src/logics/uniswap-v3/configs.ts Show resolved Hide resolved
src/logics/uniswap-v3/configs.ts Show resolved Hide resolved
hihiben
hihiben approved these changes Oct 13, 2023
View reviewed changes
Copy link

@hihiben hihiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chouandy
chouandy reviewed Oct 13, 2023
View reviewed changes
src/utils/tokens.ts Outdated Show resolved Hide resolved
src/utils/tokens.test.ts Outdated Show resolved Hide resolved
src/logics/utility/logic.send-token.ts Outdated Show resolved Hide resolved
src/logics/utility/logic.multi-send.ts Outdated Show resolved Hide resolved
chouandy
chouandy reviewed Oct 16, 2023
View reviewed changes
src/utils/tokens.ts Outdated Show resolved Hide resolved
@Jeff-CCH Jeff-CCH force-pushed the feat/support_Base_Metis_Optimism_Avalanche branch from 0f3b32c to ffb26bb Compare October 16, 2023 07:00
chouandy
chouandy approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@chouandy chouandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jeff-CCH Jeff-CCH merged commit 31790e2 into dinngo:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zodahu zodahu zodahu left review comments

@hihiben hihiben hihiben approved these changes

@chouandy chouandy chouandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jeff-CCH @zodahu @chouandy @hihiben