Add Permit2 Pull Token Logics #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jeff-CCH
commented
Nov 17, 2023
•
Jeff-CCH
commented
- pull token
- test
- yarn changeset
Jeff-CCH
force-pushed
the
feat/integrate-permit2
branch
2 times, most recently
from
755db43 to
1a965f1
Compare
chouandy
reviewed
Nov 22, 2023
There was a problem hiding this comment.
I'm wondering whether it's necessary to maintain another set of permit2 addresses and typechains within logics. Since Logic inherits from RouterKit, we can retrieve the permit2 address through the agent implementation. cc @zodahu
https://github.com/dinngo/protocolink-js-sdk/blob/master/packages/core/src/router-kit.ts#L61
https://github.com/dinngo/protocolink-js-sdk/blob/master/packages/core/src/router-kit.ts#L73
Jeff-CCH
force-pushed
the
feat/integrate-permit2
branch
from
1a965f1 to
7dc860e
Compare
chouandy
reviewed
Nov 22, 2023
Jeff-CCH
force-pushed
the
feat/integrate-permit2
branch
from
7dc860e to
4abbf19
Compare
Jeff-CCH
force-pushed
the
feat/integrate-permit2
branch
from
4abbf19 to
8cccf10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.